Skip to content

Trigger an E_USER_ERROR whenever a curl request fails (#90) #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Trigger an E_USER_ERROR whenever a curl request fails (#90) #104

wants to merge 1 commit into from

Conversation

colinodell
Copy link
Contributor

Fixes #90

This is one of three possible solutions to #90 (will submit and link the other two options shortly)

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 2, 2018
This was referenced Oct 2, 2018
Closed
Merged
@colinodell colinodell force-pushed the trigger-error-on-curl-failure branch from 2c4d52b to fde3a52 Compare October 2, 2018 14:15
@codecov
Copy link

codecov bot commented Oct 2, 2018 •
edited
Loading

Codecov Report

Merging #104 into master will increase coverage by 5.41%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
+ Coverage    84.7%   90.11%   +5.41%     
==========================================
  Files           3        3              
  Lines         170      172       +2     
==========================================
+ Hits          144      155      +11     
+ Misses         26       17       -9
Impacted Files Coverage Δ
lib/Client.php 88.11% <100%> (+6.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9a04d9...fde3a52. Read the comment docs.

@colinodell colinodell mentioned this pull request Oct 2, 2018
Closed
@thinkingserious thinkingserious added status: waiting for feedback waiting for feedback from the submitter and removed status: code review request requesting a community code review or review from Twilio labels Oct 3, 2018
@colinodell
Copy link
Contributor Author

Closing in favor of #103

@colinodell colinodell closed this Oct 4, 2018
@colinodell colinodell deleted the trigger-error-on-curl-failure branch October 4, 2018 01:32
@devchas devchas added difficulty: medium fix is medium in difficulty hacktoberfest status: work in progress Twilio or the community is in the process of implementing type: community enhancement feature request not on Twilio's roadmap labels Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: waiting for feedback waiting for feedback from the submitter status: work in progress Twilio or the community is in the process of implementing type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document and throw an error to help people with CURLOPT_SSL_VERIFYPEER issues
3 participants
@colinodell @thinkingserious @devchas